fix: Cast value to string in validation check#17376
Open
wojtekojtek wants to merge 1 commit intonextcloud:mainfrom
Open
fix: Cast value to string in validation check#17376wojtekojtek wants to merge 1 commit intonextcloud:mainfrom
wojtekojtek wants to merge 1 commit intonextcloud:mainfrom
Conversation
Fixes exception: Exception preg_match(): Argument nextcloud#2 ($subject) must be of type string, false given in file '/var/www/html/nextcloud/apps/spreed/lib/MatterbridgeManager.php' line 505 Signed-off-by: wojtekojtek <49075395+wojtekojtek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes exception:
Exception preg_match(): Argument #2 ($subject) must be of type string, false given in file '/var/www/html/nextcloud/apps/spreed/lib/MatterbridgeManager.php' line 505
validateParts() iterates over all keys/values of each bridge part and calls
preg_match() on them directly. Boolean fields like
skiptls(which is falseby default) are not cast to string first, causing a fatal exception that
prevents any bridge config from being saved.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required