Skip to content

fix(filtering): Do not show filter unread mentions button while filtering#16634

Merged
Antreesy merged 2 commits intonextcloud:mainfrom
max65482:fix/filtering-unread-mention-button
Mar 12, 2026
Merged

fix(filtering): Do not show filter unread mentions button while filtering#16634
Antreesy merged 2 commits intonextcloud:mainfrom
max65482:fix/filtering-unread-mention-button

Conversation

@max65482
Copy link
Contributor

@max65482 max65482 commented Dec 26, 2025

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
before after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Integrations with Files sidebar and other apps
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen
Copy link
Member

It would still make sense when we are filtering by conversation names or for meeting conversations or unread messages in general?

@Antreesy
Copy link
Contributor

Yeah, I'd say original issue is unclear about this. Button should not be shown, only if there are unread conversations out of screen, not when filtering

@max65482
Copy link
Contributor Author

max65482 commented Jan 13, 2026

Not sure if I got this right. Currently the button is hidden when filtering (for anything).
But it should only be hidden when filtering for unread mentions, right?

@Antreesy
Copy link
Contributor

But it should only be hidden when filtering for unread mentions, right?

It should only be hidden, when:

  • filtering unread mentions specific;
  • all unread mentions are visible on screen;
    E.g. you filter for unread messages, and there are still mentions down the list - button should be shown
    You fiter for unread mentions, and there is still mentions down the list - doesn't really relevant to show button, they're all mentions

@max65482 max65482 marked this pull request as ready for review January 14, 2026 16:45
@max65482
Copy link
Contributor Author

Thanks for the clarification! Changed that.

…ring

Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
…specifically

Signed-off-by: Maximilian Martin <maximilian_martin@gmx.de>
@Antreesy Antreesy force-pushed the fix/filtering-unread-mention-button branch from f90e126 to 60083b9 Compare March 12, 2026 18:05
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! Sorry it took so long, got lost in notifications... 🙏🏽

@Antreesy Antreesy merged commit 5a3e781 into nextcloud:main Mar 12, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant unread mention button when filtering for unread mentions

3 participants