feat(LeftSidebar): add global Talk messages search #16344
Conversation
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
3. to review
enhancement
feature: frontend 🖌️
| async fetchMessagesEverywhere() { | ||
| try { | ||
| this.messagesLoading = true |
There was a problem hiding this comment.
This has no use in this case
| const response = await request({ | ||
| term: this.searchText, | ||
| limit: 5, |
There was a problem hiding this comment.
This is misleading as it lacks Show more messages button when there can be more results to show
There was a problem hiding this comment.
I don't see a "see more" in the screenshot, so how would we see older results?
Antreesy
changed the title
| await Promise.all([ | ||
| this.fetchPossibleConversations(), | ||
| this.fetchListedConversations(), | ||
| this.fetchMessagesEverywhere(), | ||
| ]) |
There was a problem hiding this comment.
We wanted to have the global search as an additional action, not the default, didn't we?
There was a problem hiding this comment.
I'd vote for it being the default.
in case that it not possible, add some filter chips on the top row like ✔️ Conversations ✔️People Messages, so that it is visible that global message search is possible
Edit: the filter chips would be useful either way as the space available is not that much.
There was a problem hiding this comment.
I'd vote for it being the default.
This is quite problematic. A lot of people use the quick filtering to navigate to other conversations, if that always triggers yet another search request, it adds quite some load, while sometimes people might know already where they need to go.
Just for the record, on our server we have:
- ~1.8k requests for open conversations today with a search term coming from the left sidebar filtering (we should look into reducing those as well)
- ~150 unified searches
- ~30 searches in the current conversation
So if we "all of a sudden" add 1.8k additional search requests it should be sensible and optional from my pov
There was a problem hiding this comment.
We can also try to put all the factual search results behind a click (e.g. initially show only joined group and private conversations matching search term):
There was a problem hiding this comment.
This is quite problematic. A lot of people use the quick filtering to navigate to other conversations, if that always triggers yet another search request, it adds quite some load, while sometimes people might know already where they need to go.
Got it, exactly why I proposed the filter chips idea :) By default it can be unselected and if people select it we can trigger the global message search.
We should at some point consolidate the right sidebar message "in this conversation" message search and the global search too, and we can make the use of more filters. eg:
nickvergessen
modified the milestones:
v23.0.0-beta.1,
🍏 Next Beta (33),
v23.0.0-beta.2,
🍏 Next RC (33)
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist