fix(templates): include ooxml types in form filling - #6024
Merged
Conversation
elzody
force-pushed
the
fix/ooxml-template-form-filling
branch
from
September 3, 2026 14:44
54b4d71 to
caf07ac
Compare
elzody
marked this pull request as ready for review
September 3, 2026 14:45
moodyjmz
approved these changes
Sep 3, 2026
moodyjmz
left a comment
moodyjmz
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — this matches the array_merge(MIMETYPES, MIMETYPES_MSOFFICE) guard already used in FileCreatedFromTemplateListener.php:39, and the new test actually exercises the OOXML case that was broken.
Minor, non-blocking: this union is now duplicated in two places, and AppConfig::getMimeTypes() already computes almost the same thing — could be a shared helper at some point.
Collaborator
Author
|
The failures are not related to this. The tests pass when run against stable Collabora, but nightly fails due to an unrelated error. I've already raised it with Collabora. |
MS office MIME types should be considered in addition to OpenDocument types when creating a document from a template. This allows support for form filling on the MS office document types Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzody
force-pushed
the
fix/ooxml-template-form-filling
branch
from
September 3, 2026 19:40
caf07ac to
8ad491e
Compare
Collaborator
Author
|
/backport to stable35 |
Collaborator
Author
|
/backport to stable34 |
Collaborator
Author
|
/backport to stable33 |
Collaborator
Author
|
/backport to stable32 |
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MS office MIME types should be considered in addition to OpenDocument
types when creating a document from a template. This allows support for
form filling on the MS office document types
Assisted-by: ClaudeCode:claude-sonnet-5
Checklist