Skip to content

Log inability to load viewer - #4915

Merged
elzody merged 3 commits into
nextcloud:mainfrom
JAicewizard:JAicewizard-patch-1
Jul 29, 2025
Merged

Log inability to load viewer#4915
elzody merged 3 commits into
nextcloud:mainfrom
JAicewizard:JAicewizard-patch-1

Conversation

@JAicewizard

Copy link
Copy Markdown
Contributor
  • Resolves: No registered issue
  • Target version: main

Summary

JS pages often have irrelevant errors in the console, this adds the explicit error making it easy to sysadmins to know the reason why this app isn't working

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

JS pages often have irrelevant errors in the console, this adds the explicit error making it easy to sysadmins to know the reason why this app isn't working

Signed-off-by: Jaap Aarts <JAicewizard@users.noreply.github.com>
Comment thread src/viewer.js Outdated
JAicewizard and others added 2 commits July 29, 2025 00:33
Co-authored-by: Elizabeth Danzberger <elizabeth@elzody.dev>
Signed-off-by: Jaap Aarts <JAicewizard@users.noreply.github.com>
fix single quotes

Signed-off-by: Jaap Aarts <JAicewizard@users.noreply.github.com>
@elzody

elzody commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

Thanks a lot for your contribution. We are having a conference in September and it would be great if you would consider coming to hang out: https://nextcloud.com/conference-2025/. We can sometimes provide travel support in case you need assistance.

Nonetheless, the changes look good, so we can go ahead and merge them.
@JAicewizard

@elzody

elzody commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

/backport to stable31

@elzody

elzody commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator

/backport to stable30

@elzody
elzody merged commit 550746b into nextcloud:main Jul 29, 2025
52 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@JAicewizard
JAicewizard deleted the JAicewizard-patch-1 branch August 12, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants