Used Material Icon instead of emoji in settings (#4872) - #4874
Closed
Solomon-mithra wants to merge 2 commits into
Closed
Used Material Icon instead of emoji in settings (#4872)#4874Solomon-mithra wants to merge 2 commits into
Solomon-mithra wants to merge 2 commits into
Conversation
Signed-off-by: Solomon Mithra <solomonmithra99@gmail.com> Use Material Icon instead of emoji in settings (nextcloud#4872)
Solomon-mithra
force-pushed
the
Used-Material-Icon-instead-of-emoji
branch
from
June 28, 2025 08:48
5cd6e58 to
ce69375
Compare
Collaborator
|
Looks great, you would just need to rebase on top of the latest main branch and run |
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
|
Can you please rebase on the latest main branch of richdocuments? It should resolve the test failures, and then you can run |
Collaborator
|
I am closing this pull request so that I can make the changes myself. You will still be reflected as the author of the commits and you will be attributed in the release, so no worries about that. I was working on another issue and thought this PR would make a great addition alongside it, so that is my reasoning. You can find the new pull request here: #4921 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced the CSS鈥恇ased emoji folder icon with the
FolderIconMaterial SVG component in the Personal Settings view (PersonalSettings.vue). This improves accessibility and ensures a consistent look with other Material icons used in the app.TODO
Checklist