Skip to content

Used Material Icon instead of emoji in settings (#4872) - #4874

Closed
Solomon-mithra wants to merge 2 commits into
nextcloud:mainfrom
Solomon-mithra:Used-Material-Icon-instead-of-emoji
Closed

Used Material Icon instead of emoji in settings (#4872)#4874
Solomon-mithra wants to merge 2 commits into
nextcloud:mainfrom
Solomon-mithra:Used-Material-Icon-instead-of-emoji

Conversation

@Solomon-mithra

@Solomon-mithra Solomon-mithra commented Jun 28, 2025

Copy link
Copy Markdown
Contributor

Summary

Replaced the CSS鈥恇ased emoji folder icon with the FolderIcon Material SVG component in the Personal Settings view (PersonalSettings.vue). This improves accessibility and ensures a consistent look with other Material icons used in the app.

TODO

  • Verify the tooltip appears correctly on hover
  • Confirm no visual regressions in other settings sections

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Signed-off-by: Solomon Mithra <solomonmithra99@gmail.com>

Use Material Icon instead of emoji in settings (nextcloud#4872)
@Solomon-mithra
Solomon-mithra force-pushed the Used-Material-Icon-instead-of-emoji branch from 5cd6e58 to ce69375 Compare June 28, 2025 08:48
@elzody

elzody commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

Looks great, you would just need to rebase on top of the latest main branch and run npm run lint:fix to resolve most of the CI failures. After that we can get it in.

@github-actions

This comment was marked as off-topic.

@elzody

elzody commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

Can you please rebase on the latest main branch of richdocuments? It should resolve the test failures, and then you can run npm run lint:fix to resolve the linting errors.

@Solomon-mithra

@elzody

elzody commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

I am closing this pull request so that I can make the changes myself. You will still be reflected as the author of the commits and you will be attributed in the release, so no worries about that. I was working on another issue and thought this PR would make a great addition alongside it, so that is my reasoning.

You can find the new pull request here: #4921

@elzody elzody closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Material Icon instead of emoji in settings

2 participants