Skip to content

fix(attachements): unify icons with the rest of nextcloud#12421

Open
hamza221 wants to merge 2 commits intomainfrom
fix/attachement-icons
Open

fix(attachements): unify icons with the rest of nextcloud#12421
hamza221 wants to merge 2 commits intomainfrom
fix/attachement-icons

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Feb 13, 2026

Use OCP\Files\IMimeTypeDetector instead of custom icons to maintain the same UI across all of Nextcloud

b a
image image

@hamza221
Copy link
Contributor Author

/backport to stable5.7

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 force-pushed the fix/attachement-icons branch from 9527435 to c7b3c4e Compare February 13, 2026 16:40
@kesselb
Copy link
Contributor

kesselb commented Feb 13, 2026

Failure related:

1) OCA\Mail\Tests\Integration\Service\DraftServiceIntegrationTest::testSaveAndGetMessage
TypeError: OCA\Mail\Service\Attachment\AttachmentService::__construct(): Argument #8 ($mimeTypeDetector) must be of type OCP\Files\IMimeTypeDetector, Psr\Log\NullLogger given, called in /home/runner/actions-runner/_work/mail/mail/nextcloud/apps/mail/tests/Integration/Service/DraftServiceIntegrationTest.php on line 95

Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants