fix: Catch exceptions at Circle::getInitiator during mountpoint setup

[mejo-]

Extracted from #2229 and adapted

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits

[max-nextcloud]

I'm not sure I understand well enough what you are trying to do. So let me try and write it down so you can check if it's matching:

• Some code inside getCollectivesForUser may throw an exception.
• As this is during mount point setup that will break a lot of requests - basically all requiring a filesystem to be setup.
• Since the code in question may live in the circles app and may be a bug / syntax error we cannot rely on the exception types we usually have.
• Therefore we catch and log all exceptions in this critical code path.

Assuming that's your goal I agree with it. However this generic catching of exceptions will also catch errors in our own code - even syntax errors and only report them as log entries. I'm not a fan of simply logging unexpected errors - as they may remain unnoticed for quite a while. 500 responses scream - there's something wrong on the server - look at the logs. Log entries alone are quiet in many contexts (for example our current CI).

Instead I'd prefer to keep the scope of generic error handling as small as possible. I.e. catching generic exceptions thrown by circles, rethrowing them as our own Exception - for example CircleException and only adding that to the exceptions caught in the MountProvider.

[mejo-]

Thanks for your thoughts @max-nextcloud

Assuming that's your goal I agree with it.

Yes, you nailed it 😆

I'm not a fan of simply logging unexpected errors - as they may remain unnoticed for quite a while.

Indeed, I agree.

Instead I'd prefer to keep the scope of generic error handling as small as possible. I.e. catching generic exceptions thrown by circles, rethrowing them as our own Exception - for example CircleException and only adding that to the exceptions caught in the MountProvider.

This sounds like a good way forward to me 👍

[mejo-]

@max-nextcloud I refactored the change now to only catch generic exceptions at Circle::getInitiator() for now as this was the original problem.