Conversation
There was a problem hiding this comment.
@nilsbehlen can you fix the failing DCO check ?
see https://github.com/nextcloud/app-certificate-requests/pull/896/checks?check_run_id=62592263738
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
as said, DCO check is failing
…extcloud-app Previous key is lost. Signed-off-by: Nils Behlen <nils.behlen@netknights.it>
nilsbehlen
force-pushed
the
replace-privacyidea
branch
from
be13117 to
ff12031
Compare
|
@mgallien i have updated the commit |
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
can you check the common name (CN) of the certificate signing request ?
seems like the github CI check is failing
see https://github.com/nextcloud/app-certificate-requests/actions/runs/21704980922
…extcloud-app Previous key is lost. Signed-off-by: Nils Behlen <nils.behlen@netknights.it>
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
can I have some help from @lukasmatusiewicz ?
I would like to be sure everybody is OK with us delivering a new certificate to another contributor github id (I have checked and @nilsbehlen is an active contributor of privacyidea)
sorry for asking now but I want to be careful
|
Hi again @mgallien, |
|
hey, i get this error when im trying to generate the file: can you please merge the commit or push another one: |
|
Hi @GretaD what do you mean? Should i open a new PR? in this PR i updated the file because it failed your DCO check. |
|
Yes, opening a new one sounds good. Maybe because there are 2 commits, it doesnt allow to generate the certificate. |
|
@nilsbehlen any news ? |
3 participants
https://github.com/privacyidea/privacyidea-nextcloud-app
Previous key is lost.