Skip to content

Update certificate request in social.csr#892

Merged
mgallien merged 2 commits intonextcloud:masterfrom
SchBenedikt:patch-2
Mar 6, 2026
Merged

Update certificate request in social.csr#892
mgallien merged 2 commits intonextcloud:masterfrom
SchBenedikt:patch-2

Conversation

@SchBenedikt
Copy link
Copy Markdown
Contributor

@SchBenedikt SchBenedikt commented Jan 30, 2026

Signed-off-by: Benedikt Schächner <benedikt.schaechner@web.de>
Copilot AI review requested due to automatic review settings January 30, 2026 15:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundled certificate signing request (CSR) for the Nextcloud Social app.

Changes:

  • Replaced the existing social CSR payload with a newly generated CSR.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nextcloud nextcloud deleted a comment from Copilot AI Jan 30, 2026
Copy link
Copy Markdown
Contributor

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchBenedikt seems like the Copilot comment was on purpose
please update the CSR to have the app id as the CN requested 🙏

Copy link
Copy Markdown
Contributor Author

@SchBenedikt SchBenedikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Benedikt Schächner <benedikt.schaechner@web.de>
@SchBenedikt SchBenedikt requested a review from mgallien March 4, 2026 20:04
@SchBenedikt
Copy link
Copy Markdown
Contributor Author

Hello, it should finally work now!

mgallien added a commit that referenced this pull request Mar 6, 2026
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien merged commit 809d29c into nextcloud:master Mar 6, 2026
2 checks passed
@mgallien
Copy link
Copy Markdown
Contributor

mgallien commented Mar 6, 2026

@SchBenedikt you can find the new certificate here cad0da3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants