Skip to content

Clean up the mess#952

Merged
Ian0sborne merged 15 commits intonext-exp:masterfrom
gonzaponte:cleanup
Apr 20, 2026
Merged

Clean up the mess#952
Ian0sborne merged 15 commits intonext-exp:masterfrom
gonzaponte:cleanup

Conversation

@gonzaponte
Copy link
Copy Markdown
Collaborator

@gonzaponte gonzaponte commented Mar 2, 2026 •
edited
Loading

This PR:

  • Removes Penthesilea out of the way so we don’t need to maintain it going forward
  • Cleans up unused files, imports, variables, and other dead code
  • Makes no changes to production logic — this is purely cosmetic
  • Adds pyflakes to the dependencies and a GHA step that verifies the source files for errors or unused code.

@gonzaponte gonzaponte force-pushed the cleanup branch 2 times, most recently from abd3aaa to 1f08c2a Compare March 5, 2026 10:07
@gonzaponte gonzaponte mentioned this pull request Mar 16, 2026
Open
@jwaiton jwaiton self-requested a review March 17, 2026 16:19
jwaiton
jwaiton requested changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jwaiton jwaiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad to see a museum being opened 🥳

I have a few relatively mundane comments, otherwise it looks ready to go!

Comment thread invisible_cities/database/test_data/dst_NEXT_v1_00_05_Kr_ACTIVE_0_0_7bar_PMP_10evt.h5 Outdated
Comment thread invisible_cities/cities/beersheba.py
Comment thread invisible_cities/core/testing_utils_test.py Outdated
Comment thread invisible_cities/reco/corrections_test.py Outdated
jwaiton
jwaiton approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jwaiton jwaiton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implements some 'spring cleaning' of the repository, removing an unused city and all its related components, improving the cosmetics and implementing pyflakes within our GHA testing suite.

Great work :)

@Ian0sborne Ian0sborne merged commit 163a3f1 into next-exp:master Apr 20, 2026
1 check passed
@gonzaponte gonzaponte deleted the cleanup branch April 20, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwaiton jwaiton jwaiton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gonzaponte @jwaiton @Ian0sborne