Skip to content

Update scikit-learn Tests#1691

Open
TimPansino wants to merge 3 commits intomainfrom
update-sklearn-tests
Open

Update scikit-learn Tests#1691
TimPansino wants to merge 3 commits intomainfrom
update-sklearn-tests

Conversation

@TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Mar 16, 2026

Overview

  • Update tests for scikit-learn to be valid for versions >=1.8.0
  • Also unpins starlette tests which are working fine on the latest version and do not need the pin.

@TimPansino TimPansino requested a review from a team as a code owner March 16, 2026 21:50
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 1.12s
✅ MARKDOWN markdownlint 7 0 0 0 1.4s
✅ PYTHON ruff 1030 0 0 0 1.17s
✅ PYTHON ruff-format 1030 0 0 0 0.35s
✅ YAML prettier 15 0 0 0 1.64s
✅ YAML v8r 15 0 0 5.71s
✅ YAML yamllint 15 0 0 0.71s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@TimPansino TimPansino force-pushed the update-sklearn-tests branch 2 times, most recently from 253bc8b to 5d298c0 Compare March 16, 2026 21:57
@TimPansino TimPansino force-pushed the update-sklearn-tests branch from 5d298c0 to be7025e Compare March 16, 2026 22:07
@mergify mergify bot added the tests-failing Tests failing in CI. label Mar 16, 2026
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (0aeec05) to head (be7025e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1691      +/-   ##
==========================================
- Coverage   81.89%   81.78%   -0.11%     
==========================================
  Files         214      214              
  Lines       25672    25672              
  Branches     4071     4071              
==========================================
- Hits        21025    20997      -28     
- Misses       3254     3275      +21     
- Partials     1393     1400       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests-failing Tests failing in CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants