Merged
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
d5546c8 to
4ef3072
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
==========================================
+ Coverage 81.05% 81.55% +0.49%
==========================================
Files 205 205
Lines 23216 23200 -16
Branches 3669 3671 +2
==========================================
+ Hits 18817 18920 +103
+ Misses 3186 3054 -132
- Partials 1213 1226 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ff11cec to
6fa7eec
Compare
a96178a to
f9765cb
Compare
382ecba to
3d8517a
Compare
hmstepanek
previously approved these changes
May 23, 2025
|
|
||
| def __enter__(self): | ||
| transaction = current_transaction() | ||
| if not transaction: |
Contributor
There was a problem hiding this comment.
It's surprising to me that this has been wrong for so long but I don't actually see in the existing code where it is gated by this check higher up so this seems correct to me.
hmstepanek
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
pyflakeslinter inruff.pyflakesviolations.openai,kombu, andpsycopg2instrumentation (noticed due to linter violations).