NMODL: Supress unwanted error messages#3741
Open
ctrl-z-9000-times wants to merge 2 commits intoneuronsimulator:masterfrom
Open
NMODL: Supress unwanted error messages#3741ctrl-z-9000-times wants to merge 2 commits intoneuronsimulator:masterfrom
ctrl-z-9000-times wants to merge 2 commits intoneuronsimulator:masterfrom
Conversation
Currently NMODL prints error messages if there are DERIVATIVE blocks with no associated solver method. The matexp solver removes the SOLVE statement from derivative blocks, but leaves the derivative blocks in case there is also a STEADYSTATE solver for the block, which causes false-positive errors. Having a unsolved derivative block should be at most a warning, and the current error message was also unclear: "solver method '' not supported" I fixed this so that now, if the solver method is unspecified, it emits no errors or warnings.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3741 +/- ##
==========================================
- Coverage 68.31% 68.30% -0.01%
==========================================
Files 689 689
Lines 111034 111034
==========================================
- Hits 75855 75847 -8
- Misses 35179 35187 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently NMODL prints error messages if there are DERIVATIVE blocks with no associated solver method. However, the matexp solver removes the SOLVE statement from derivative blocks, but leaves the derivative blocks in case there is also a STEADYSTATE solver for the block, which causes false-positive errors.
Having a unsolved derivative block should be at most a warning, and the current error message was also unclear: "solver method '' not supported"
I fixed this so that now, if the solver method is unspecified, it emits no errors or warnings.