Skip to content

Fixed a MPI bug with MultiCompartmentReaction which produce membrane currents.#3736

Open
adamjhn wants to merge 2 commits intomasterfrom
rxd_mpi_mcr_fix
Open

Fixed a MPI bug with MultiCompartmentReaction which produce membrane currents.#3736
adamjhn wants to merge 2 commits intomasterfrom
rxd_mpi_mcr_fix

Conversation

@adamjhn
Copy link
Copy Markdown
Member

@adamjhn adamjhn commented Mar 26, 2026

In initialize_multicompartment_reaction when mpi flag is used reaction_indices were free after being copied to all_reaction_indices. This caused a problem if set_rxd_current was called, setting the initialize_multicompartment_reaction flag to FALSE, so all_reaction_indices get set again, having cleared the original reaction_indices.

This fix keeps two copies of reaction indices, one for the process in reaction_indices and one for all of the processes in all_reaction_indices.

@adamjhn adamjhn requested a review from ramcdougal March 26, 2026 21:01
@adamjhn adamjhn added bug rxd reaction-diffusion labels Mar 26, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.31%. Comparing base (f0fe2c5) to head (3be830c).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/grids.cpp 42.85% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3736      +/-   ##
==========================================
+ Coverage   68.28%   68.31%   +0.02%     
==========================================
  Files         689      689              
  Lines      111033   111043      +10     
==========================================
+ Hits        75816    75855      +39     
+ Misses      35217    35188      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

✔️ 6203738 -> artifacts URL

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

✔️ 3be830c -> artifacts URL

@azure-pipelines
Copy link
Copy Markdown

✔️ 3be830c -> Azure artifacts URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug rxd reaction-diffusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant