Draft
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3666 +/- ##
=======================================
Coverage 68.08% 68.09%
=======================================
Files 686 686
Lines 110904 110904
=======================================
+ Hits 75508 75516 +8
+ Misses 35396 35388 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ e443e6d -> Azure artifacts URL |
Contributor
|
✔️ e443e6d -> artifacts URL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The
mkthreadsafescript is a bit hard to follow, and error-prone due to its heavy use ofgrep. This is an attempt at rewriting it in C++ using NMODL's AST abilities. This means thatmkthreadsafeno longer depends on POSIX tooling, and is much more maintainable.TODO:
mkthreadsafeis built even withoutNRN_ENABLE_CORENEURON=ON