Conversation
* Move NMODL Python _bindings_ to its own dir * Add `NMODL_PYTHON_TARGETS` and `NMODL_DEFAULT_PYTHON_TARGET` CMake vars * Use `nrn_add_python_library` instead of `pybind11_add_module` * Install targets more selectively
|
✔️ 82edccd -> Azure artifacts URL |
|
✔️ 82edccd -> artifacts URL |
|
✔️ 5793409 -> artifacts URL |
|
✔️ 09130e7 -> artifacts URL |
|
✔️ e22aa17 -> artifacts URL |
|
✔️ e22aa17 -> Azure artifacts URL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3541 +/- ##
==========================================
+ Coverage 68.09% 68.28% +0.18%
==========================================
Files 686 686
Lines 110908 110908
==========================================
+ Hits 75525 75729 +204
+ Misses 35383 35179 -204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✔️ 63f765d -> artifacts URL |
|
✔️ 63f765d -> Azure artifacts URL |
Put back whatever hackery it used before to collect the mod files, if some of the files are missing coverage I really don't care.
also add comment about using single triple quotes
…lic/refactor_coverage
|
|
✔️ 4fa6a87 -> artifacts URL |
|
✔️ 4fa6a87 -> Azure artifacts URL |
|
|
✔️ e7dea18 -> artifacts URL |
|
✔️ e7dea18 -> Azure artifacts URL |
|
|
✔️ 295a8d8 -> artifacts URL |
|
✔️ 295a8d8 -> Azure artifacts URL |
1 participant
Needs #3544.
The
pybind/CMakeLists.txtfile is used for building two kinds of targets:While the two can technically be considered related, they should really be built separately (the former must always be built if we're building NMODL, while the latter only if
NMODL_ENABLE_PYTHON_BINDINGS=ON). Now the embedded interpreter is still built bypybind/CMakeLists.txt, while the Python bindings are inbindings/CMakeLists.txt.This is somewhat towards #3519 (at least, it would enable the possibility of considering it).
Other changes:
nrn_add_python_libraryinstead ofpybind11_add_module(latter is tied to the version of Python that FindPython discovers, while the former can use any Python specified)NMODL_PYTHON_TARGETSandNMODL_DEFAULT_PYTHON_TARGETCMake varsPYBIND11_INCLUDE_DIRinstead ofPYBIND11_INCLUDE_DIRS(the latter contains Python include dirs, while the former does not)NRN_DEFAULT_PYTHON_INCLUDES(unlessNRN_ENABLE_PYTHON_DYNAMIC=ON) instead ofPYTHON_INCLUDE_DIRSARGSinadd_custom_commandsince it's deprecated