-
Notifications
You must be signed in to change notification settings - Fork 36
Add password for SSH, AWS and GDrive config #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
53a5a05 to
274fe29
Compare
44af5de to
5c21724
Compare
350ac89 to
0c2c1b2
Compare
7c328ea to
51f7c6c
Compare
a728ae4 to
6079eb5
Compare
niksirbi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this with Google Drive on MacOS.
All went well (incl. authentication) until I trying to encrypt the credentials using the built-in macOS' security tool (as prompted). I'm pasting the exception as screenshot, because my terminal didn't allow me to properly copy the exception text.
I tried several times, including setting from scratch, but to no avail.
niksirbi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out it was the Rclone version, thanks for the tip @JoeZiminski.
The problem went away by updating Rclone from 1.65 to 1.73.
…//github.com/neuroinformatics-unit/datashuttle into add_password_to_rclone_config_for_aws_gdrive
|
@JoeZiminski I tested this on Windows 11 (rclone v1.73.0). |
|
Hey @ishan372or thanks for this! I'm a bit stumped, the only clue is that the drive is missing from your path e.g. |
|
Hi @ishan372or don't worry, I can replicate now I guess you have a space somewhere along that path? thanks! This is a very useful case that was not properly handled, will push a fix |
|
Hi @ishan372or thanks again for testing, could you try again with the latest version of this branch? |
|
@JoeZiminski , I pulled the latest commits and retested windows 11. It ran succesfully this time. |
|
Perfect, thanks @ishan372or! BTW I think #669 is complete, GitHub is having CI issues ATM but once they are fixed and the tests can run will be good to merge. Thanks a lot for that |
|
thanks. Happy to help |


This PR adds the option to encrypt the RClone config file containing SSH, AWS or GDrive connection information (e.g. private key, passwords, access tokens). The main changes are:
.conffiles (previously, the RClone default to store everything in RClone'srclone.confwas used. This is still kept forlocal_filesystemfor backwards compatibility.This required quite a lot of refactoring to the setup connection functions (API and TUI) as well as the internal calls to rclone. Now, these calls are wrapped in some functionality that handles unencrypting the rclone config if required.
Tests and documentation have been updated.
This implementation is okay but there is still room for improvement. However, as this PR is pretty big and we just need to get this out, these are reversed for the future (#636).