This repository was archived by the owner on Feb 16, 2024. It is now read-only.
Consume enumerators for types inheriting AsyncOperation.#516
Open
dogramacigokhan wants to merge 1 commit intoneuecc:masterfrom
Open
Consume enumerators for types inheriting AsyncOperation.#516dogramacigokhan wants to merge 1 commit intoneuecc:masterfrom
dogramacigokhan wants to merge 1 commit intoneuecc:masterfrom
Conversation
|
这是来自QQ邮箱的假期自动回复邮件。
您好,我最近正在忙碌中,无法亲自回复您的邮件,之后将尽快给您回复。
|
zudl
added a commit
to zudl/UniRx
that referenced
this pull request
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Enumerators for the types inheriting
AsyncOperationare not consumed as expected. AllAsyncOperations haveisDoneproperty that needs to be checked before completing the enumeration. This is done correctly for the base type by using theUnwrap...method, but the types inheriting it are handled as an unkown case.Example
Without this fix, when a webrequest is performed in Edit-mode using
UnityWebRequest.Get()andAsAsyncOperationObservableextension, the observable publishes a value immediately without waiting request to complete.Solution
Changed comparison to handle all types assignable to the
AsyncOperationbase class, so the completion is waited for them before publishing a value.