Skip to content

Plotting script added#5

Open
erlan903 wants to merge 6 commits into
netsys-lab:mainfrom
erlan903:feature/plot-results-update
Open

Plotting script added#5
erlan903 wants to merge 6 commits into
netsys-lab:mainfrom
erlan903:feature/plot-results-update

Conversation

@erlan903

@erlan903 erlan903 commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 2, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a standalone plotting utility to generate bar-chart comparisons from aggregated experiment CSV output, and updates repo config to support the new workflow.

Changes:

  • Added plot_results.py CLI to load all_results.csv, filter scenario/algorithm, and write per-metric PNG plots.
  • Added pandas and matplotlib dependencies.
  • Updated .gitignore to ignore generated plots/ output and log files.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
requirements.txt Adds plotting-related Python dependencies (pandas, matplotlib).
plot_results.py New plotting script that reads aggregated CSVs and generates per-metric bar charts.
.gitignore Ignores generated plot artifacts and *.log files.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plot_results.py Outdated
return max(candidates, key=lambda p: p.stat().st_mtime)


def validate_columns(df: pd.DataFrame, metrics: list[str]) -> None:

Copilot AI Apr 2, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metrics: list[str] uses PEP 585 built-in generics, which require Python 3.9+. The README states the project supports Python 3.8+, so this annotation will raise a TypeError on 3.8 at import time. Consider switching to typing.List[str]/Sequence[str], or adding from __future__ import annotations, or updating the documented minimum Python version.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants