Open
Conversation
Followup to neos#4058 Before the deprecated JsonView from Flow was used which rendered enums as ``` {"name": "FOO", "value": "FOO"} ``` as enums are magically json serializable, jet dont specify to implement `JsonSerializable` directly. That's way the condition `is_object($value) && $value instanceof \JsonSerializable` is skipped and all enum "properties" are serialized. https://github.com/neos/flow-development-collection/blob/9e281f9fdf8490bc409038acb2f250728fb3c614/Neos.Flow/Classes/Mvc/View/JsonView.php#L270 To fix this we use plain json_encode wich encodes enums as expected without the developer having to implement `JsonSerializable` redundantly ``` "FOO" ``` see also https://3v4l.org/OZb1n#vnull
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #4058
Before the deprecated JsonView from Flow was used which rendered enums as
as enums are magically json serializable, jet dont specify to implement
JsonSerializabledirectly.That's way the condition
is_object($value) && $value instanceof \JsonSerializableis skipped and all enum "properties" are serialized.https://github.com/neos/flow-development-collection/blob/9e281f9fdf8490bc409038acb2f250728fb3c614/Neos.Flow/Classes/Mvc/View/JsonView.php#L270
To fix this we use plain json_encode wich encodes enums as expected without the developer having to implement
JsonSerializableredundantlysee also https://3v4l.org/OZb1n#vnull
What I did
How I did it
How to verify it