BUGFIX: Avoid orphans when publishing node move

[kitsunet]

See issue for detailed explanation. In a nutshell: NodeData::setPath is dangerous as it mixes DB queries with memory state and can lead to unexpected results. Using only NodeData::move avoids the problem.

Fixes: #5763

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the correct branch:
  • If it's a bugfix, use the lowest maintained branch which has the bug
  • If it's a non-breaking feature, use the branch of the next version (might be either minor or major)
  • If it's a breaking feature it should typically go into the next major version
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kitsunet]

Right, that's what I feared to see. I guess this needs a more sophisticated solution. I'll look into it.

[kitsunet]

I added a new behat test that shows the problem without any changes to the CR. This and the other failing tests are green now. I know persisting after every node publish will slow down publishing, but I don't see a way to avoid this while also fixing the problems. If anyone finds a way, I am happy to see it. But for now, this seems safer.

[kitsunet]

Ah funny, EventLog tests fail, I didn't run them locally, but that test is fragile anyways as it checks the number of events, but that is nothing the EventLog even controls or should have information about.