Merged
Conversation
Add nil-safety to image tagging section using safe navigation operator (&.). This prevents NoMethodError when ImageCore records don't exist due to: - Empty meme directories - Missing example image files - Users mounting custom directories without example memes The fix allows seed to complete successfully and create ImageToText model records, which are needed for the Settings > Models page to display properly. Fixes issue where users reported models not showing in Settings page. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add 4 test cases to prevent seed file regressions - Test empty meme directories scenario (user's reported issue) - Test populated directories (standard setup) - Test idempotency (multiple runs don't create duplicates) - Test ImageToText model creation and attributes Changes to seed file: - Use find_or_create_by! for ImageToText models (idempotency) - Nil-safe image tagging already implemented in previous commit This ensures the "models not showing" bug cannot regress. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Patch release with bug fixes: - Fix seed file crash when meme directories are empty - Add comprehensive seed file test coverage - Use find_or_create_by! for ImageToText models (idempotency) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.