JsSymbol

[chrisbajorin]

Rendered: https://github.com/chrisbajorin/rfcs/blob/symbol-primitive/text/0000-symbol-primitive.md

[kjvalencik]

@chrisbajorin This is fantastic! Thanks so much for the contribution.

One recommended addition to this RFC, which is related in usefulness, but not directly tied to it, is adding a Eq implementation for all Value that leverages napi_strict_equals.

[chrisbajorin]

@kjvalencik In regards to Eq, are you just looking for a mention that strict equality should hold for all primitive values, or is this something that fits within the reference-level explanation? I see Eq currently has a blanket implementation on Handle<T>, so I'm not quite sure how this fits in code-wise.

[chrisbajorin]

Updated to reflect our discussion in neon-bindings/neon#761

[kjvalencik]

@chrisbajorin This looks really great! I'm going to put it into final comment period! Thanks for your contributions!

[dherman]

BTW, I just wanted to note that the description() method can be technically thought of as a convenience method, since you can implement it with other primitives, i.e. the Neon equivalent of:

const getter = Object.getOwnPropertyDescriptor(Symbol.prototype, 'description').get;
getter.call(sym)

Not a crucial point but it makes me feel confident that the description() method is a nice convenience to have and doesn't fundamentally add any complexity.