Allow extra headers of HEAD request for container/object requests.#178
Open
charz wants to merge 2 commits intoncw:masterfrom
Open
Allow extra headers of HEAD request for container/object requests.#178charz wants to merge 2 commits intoncw:masterfrom
charz wants to merge 2 commits intoncw:masterfrom
Conversation
Contributor
Author
|
I'm not sure why go1.17 failed in below, I tried to run golangci-lint looks fine in my end. |
ncw
reviewed
Sep 16, 2022
Owner
ncw
left a comment
There was a problem hiding this comment.
This breaks backwards compatibility, so you'll need to introduce a new ContainerHeaders function or similar
Contributor
Author
|
Just add two extraheaders for container and object in connection structure. Do you think that make sense? |
Owner
|
I'd prefer new functions with extra parameters otherwise you create a global state which will be difficult to share between threads. |
Contributor
Author
Do you mean something likes this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team,
I'd like to add headers support for HEAD requests that might help in some case like
X-Newest: true(#100) or some custom headers.Thanks!