Do not feed MPD's position back to itself#76
Merged
natsukagami merged 2 commits intonatsukagami:masterfrom Jan 28, 2026
Merged
Conversation
This is probably still wrong, but less obviously so: when detecting a seek from MPD, there is no reason to *tell* MPD about the seek, we can just emit a DBus signal. Ideally a signal would not be emitted when changing tracks, but I leave this as future work.
A function for computing the absolute value of a time.Duration.
natsukagami
approved these changes
Jan 27, 2026
Owner
natsukagami
left a comment
natsukagami
left a comment
There was a problem hiding this comment.
This looks reasonable. Thanks for taking a look at it!
ncfavier
added a commit
to ncfavier/nixpkgs
that referenced
this pull request
Jan 28, 2026
Fixes a difficult-to-diagnose bug where mpd skips the last half-second or so of every track.
ncfavier
added a commit
to ncfavier/nixpkgs
that referenced
this pull request
Jan 28, 2026
Fixes a difficult-to-diagnose bug where mpd skips the last half-second or so of every track.
Contributor
|
Is there a chance for a new patch release with this PR included? 🙏 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #75.
This is probably still wrong, but less obviously so: when detecting a seek from MPD, there is no reason to tell MPD about the seek, we can just emit a DBus signal.
Ideally a signal would not be emitted when changing tracks, but I leave this as future work.