chore(actions): added a toolchain for go1.24.12#83
Merged
Conversation
the release builds are getting failed because of go.sum generated with 1.24, but needing update for 1.25 - Also copied one of the checks in release to tests, to see fails during the push rather than on tagging.
philpennock
previously approved these changes
Jan 23, 2026
2eb0b77 to
83b1ce1
Compare
Pull Request Test Coverage Report for Build 21303478473Details
💛 - Coveralls |
Member
Author
|
@philpennock sorry - but this is the PR that works. The main issue is that go mod tidy doesn't require some deps on OS X, so anytime the release action tried to do go vet or go list, et all - it fails because of the go mod being read-only. I don't know if this acceptable - in the end I think we should have the check for retracted to be an action that auto-runs in the repo daily as I think that this is a valuable feature. |
philpennock
approved these changes
Jan 23, 2026
Member
philpennock
left a comment
There was a problem hiding this comment.
I like the test-release approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release workflow failing with go: updates to go.sum needed, disabled by -mod=readonly
Root Cause
go vet on linux needs transitive dependency checksums that macOS go mod tidy doesn't add:
These are transitive deps of golang.org/x/crypto and golang.org/x/sys needed only during analysis on linux.
Fixes Applied