Skip to content

chore(actions): added a toolchain for go1.24.12#83

Merged
aricart merged 3 commits intomainfrom
fix-release-action
Jan 23, 2026
Merged

chore(actions): added a toolchain for go1.24.12#83
aricart merged 3 commits intomainfrom
fix-release-action

Conversation

@aricart
Copy link
Member

@aricart aricart commented Jan 23, 2026

Problem

Release workflow failing with go: updates to go.sum needed, disabled by -mod=readonly

Root Cause

go vet on linux needs transitive dependency checksums that macOS go mod tidy doesn't add:

  • golang.org/x/net
  • golang.org/x/term
  • golang.org/x/text

These are transitive deps of golang.org/x/crypto and golang.org/x/sys needed only during analysis on linux.

Fixes Applied

  1. pushes.yaml
  • Added GOFLAGS: "-mod=mod" to integrity checks (allows go.sum updates)
  • Added install-go: false to staticcheck (prevents Go version override)
  1. release.yaml
  • Removed integrity checks (go vet, retracted check) - redundant since pushes.yaml runs them
  • Uses go-version-file: "go.mod"
  1. test-release.yaml (new)
  • Manual workflow_dispatch for testing releases with --snapshot --skip=publish
  1. .goreleaser.yml
  • Added version: 2 (required for goreleaser v2)
  • Changed format: zip → formats: [zip]
  • Changed snapshot.name_template → snapshot.version_template
  1. go.mod
  • Added toolchain go1.24.12

the release builds are getting failed because of go.sum generated with 1.24, but needing update for 1.25 - Also copied one of the checks in release to tests, to see fails during the push rather than on tagging.
@aricart aricart marked this pull request as draft January 23, 2026 19:39
philpennock
philpennock previously approved these changes Jan 23, 2026
@coveralls
Copy link

coveralls commented Jan 23, 2026

Pull Request Test Coverage Report for Build 21303478473

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.347%

Totals Coverage Status
Change from base Build 21298238181: 0.0%
Covered Lines: 417
Relevant Lines: 519

💛 - Coveralls

@aricart
Copy link
Member Author

aricart commented Jan 23, 2026

@philpennock sorry - but this is the PR that works.

The main issue is that go mod tidy doesn't require some deps on OS X, so anytime the release action tried to do go vet or go list, et all - it fails because of the go mod being read-only.

I don't know if this acceptable - in the end I think we should have the check for retracted to be an action that auto-runs in the repo daily as I think that this is a valuable feature.

@aricart aricart marked this pull request as ready for review January 23, 2026 22:40
@aricart aricart requested a review from philpennock January 23, 2026 22:40
Copy link
Member

@philpennock philpennock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the test-release approach.

@aricart aricart merged commit 0f43077 into main Jan 23, 2026
7 checks passed
@aricart aricart deleted the fix-release-action branch January 23, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants