Reports: styling & other usability improvements to Vega-Lite visualizations#2540
Open
emilyanndavis wants to merge 4 commits intonatcap:mainfrom
Open
Conversation
…ions from overflowing container or overlapping one another; remove no-longer-needed .vega-fit-horizontal styles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2532. Specifically, Vega-Lite visualizations (e.g., vector plots) are now styled to prevent them from overflowing their containers or overlapping one another. With this change, the
.vega-fit-horizontalstyles no longer appear to be needed, so I removed them.I also snuck in a few other small improvements, namely:
InVEST-{elementId}, where theelementIdis theidof the HTML element that contains the visualization. This ID is defined by the report author and is typically a short name that identifies the purpose of the visualization, e.g.,cases_map,habitat_map, orexposure_histogram.Examples
Vector plots scale down at smaller viewport widths
New default filename when saving an SVG or PNG
Vega actions menu button, before
Vega actions menu button, after
Checklist
- [ ] Updated the user's guide (if needed)