Add user feedback on attempt to load datastack with unrecognized model ID#2539
Open
emilyanndavis wants to merge 5 commits intonatcap:mainfrom
Open
Add user feedback on attempt to load datastack with unrecognized model ID#2539emilyanndavis wants to merge 5 commits intonatcap:mainfrom
emilyanndavis wants to merge 5 commits intonatcap:mainfrom
Conversation
… it's shown even when model ID is unrecognized.
…model ID via home tab "Browse…" button.
…stack-model-id-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2489. Specifically, attempting to load a datastack/logfile with an unrecognized model ID (via any Workbench-provided method) now presents an error message instead of failing silently.
Examples
Plugin ID missing version info, via setup tab
Plugin ID missing version info, via home tab
Malformed model ID (kebab case instead of snake case), via setup tab
Malformed model ID (kebab case instead of snake case), via home tab
Other unrecognized model ID, via setup tab
Other unrecognized model ID, via home tab
Checklist
- [ ] Updated the user's guide (if needed)