Bugfix for formatting of Workbench application log messages#2523
Merged
emilyanndavis merged 5 commits intonatcap:mainfrom Apr 30, 2026
Merged
Bugfix for formatting of Workbench application log messages#2523emilyanndavis merged 5 commits intonatcap:mainfrom
emilyanndavis merged 5 commits intonatcap:mainfrom
Conversation
emilyanndavis
requested changes
Apr 30, 2026
Member
emilyanndavis
left a comment
emilyanndavis
left a comment
There was a problem hiding this comment.
Looks reasonable to me, @davemfish; thanks! All I found was a typo.
Co-authored-by: Emily Davis <emilyanndavis@gmail.com>
emilyanndavis
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the inaccuracies in the label on the log messages. It's still not very precise. This does not label with filenames (that was never working properly anyhow) but it does label with either "main" or "renderer". Labeling with filename would require a new instance of the logger for each file that does logging, and that seemed excessive.
Fixes #2522
Checklist