Draft
Conversation
FBruzzesi
added
enhancement
FBruzzesi
changed the title
SQLExpr.filter method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opening as RFC because support is not for all methods - I am specifically excluding
len, but I might be missing some other cases.As hinted in a comment in the test, for
lenwe can get the right result only if there are no nulls, which of course we cannot guarantee. I am checking if there is another way, but for now I am explicitly raising a NotImplementedErrorWhat type of PR is this? (check all applicable)
Related issues
Expr.filterfor spark-like backends #2203Checklist