Open
Conversation
FBruzzesi
commented
Jan 31, 2026
| dtype: Data type that the object will be cast into. | ||
|
|
||
| Note: | ||
| Unlike polars, we don't allow to cast from a temporal to a numeric data type. |
Member
Author
There was a problem hiding this comment.
TIL: polars allows also casting to Float, not only to Integer
Member
Author
|
Test was failing due to |
FBruzzesi
commented
Jan 31, 2026
Comment on lines
+254
to
+262
| schema: dict[str, DType] = {} | ||
| with suppress(Exception): | ||
| schema = df.collect_schema() | ||
|
|
||
| if schema: | ||
| for name in self._evaluate_output_names(df): | ||
| _validate_cast_temporal_to_numeric( | ||
| source=schema[name], target=dtype | ||
| ) |
Member
Author
There was a problem hiding this comment.
I am not particularly proud of this piece of code 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It aligns with the decision of not following polars in supertyping between temporal and numeric in #3396.
Questions/Observations:
dtype.is_numeric(), this is to avoid having to trigger acollect_schema()if there is no need for itWhat type of PR is this? (check all applicable)
Related issues
Checklist