Add Context variants for Send and Receive#325
Conversation
|
You kept the gofmt a separate commit, so it's all good. :-) I've always done the go fmt thing, but its been a while and newer versions of go have probably changed things. |
|
I have mixed feelings about this ... not be cause I dislike using contexts, I think contexts are great -- mangos was designed before they existed is all. My hesitation here is two fold:
Let me think on this -- but think about the second point. I want to come to a solution here, but we might need to be willing to make a bigger change ... like another major version of mangos. |
Yeah, I was really torn about that bit too. I did feel like allowing the stdlib to be called
Yeah, having context as required would seem to follow the Go convention for IO these days. I could see the argument for
|
Rationale
Closes #215 and fixes a double lock bug.
Note
A number of files were updated due to running
go fmt. Happy to revert those and submit as a separate PR.