Migrate ST repositories in dev containers to official STMicroelectronics repos

[Copilot]

• Add set -euo pipefail to git-pull-repos.sh
• Guard all cd calls with || exit 1

[josesimoes]

LGTM

[josesimoes]

@copilot looks like Dockerfile.ThreadX container is also using the ST repositories. Please fix that one too. Make sure to bump the respective version.

[Copilot]

@copilot looks like Dockerfile.ThreadX container is also using the ST repositories. Please fix that one too. Make sure to bump the respective version.

Fixed in fd62b44 — migrated Dockerfile.ThreadX.SRC to official STMicroelectronics repos (F4/F7/H7/L4 HAL drivers + their CMSIS device packages + cmsis_core), matching the same tags used in STM32_CubePackage.cmake. Version bumped to v1.40.

[josesimoes]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Bumped development container base images (All, ChibiOS, ThreadX).
  • Migrated STM32 support to official ST repos and split HAL/CMSIS sources into separate clones/layers.
  • Made repo fetches shallow and tag-pinned; moved ChibiOS-Contrib clone into its own step.
  • Hardened repo update script with strict failure handling and safer directory checks.
  • Replaced a single STM32 template variable with three granular STM32 path variables; updated comments.

Walkthrough

Updates devcontainer base images and migrates STM32 source fetches from nanoFramework forks to official ST HAL driver and CMSIS repositories; adjusts git pull script for shallow, tag-pinned checkouts and adds finer-grained CMake/config cache variables for STM32 package sources.

Changes

Cohort / File(s)	Summary
Docker base image updates .devcontainer/All/Dockerfile.All, .devcontainer/ChibiOS/Dockerfile.ChibiOS, .devcontainer/ThreadX/Dockerfile.ThreadX	Bumped devcontainer base image tags (All v2.64→v2.65; ChibiOS v1.39→v1.40; ThreadX v1.39→v1.40).
Docker STM32 source changes .devcontainer/All/Dockerfile.All.SRC, .devcontainer/ChibiOS/Dockerfile.ChibiOS.SRC, .devcontainer/ThreadX/Dockerfile.ThreadX.SRC	Replaced nanoFramework STM32Cube repo clones with official ST repositories: separate stm32*xx_hal_driver and cmsis_device_/cmsis_core clones, each pinned to explicit version tags; ChibiOS-Contrib clone moved to its own RUN layer.
Repository pull script .devcontainer/All/scripts/git-pull-repos.sh	Enabled strict shell error handling (set -euo pipefail); switched STM32 HAL/CMSIS updates to shallow git fetch --depth=1 origin tag <version> + git checkout tags/<version> per repo; added `
CMake informational comments CMake/Modules/STM32_CubePackage.cmake	Updated comments to state STM32 HAL/CMSIS sources are retrieved from official ST repositories instead of nanoFramework forks (no logic changes).
Build config template config/user-tools-repos.TEMPLATE.json	Replaced single STM32_CUBE_PACKAGE_SOURCE cache variable with three specific variables: STM32_HAL_DRIVER_SOURCE, STM32_CMSIS_DEVICE_SOURCE, and STM32_CMSIS_CORE_SOURCE in both local and container presets.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

Type: enhancement, Type: dependencies

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main objective of migrating ST repositories to official sources across dev containers, though it exceeds the recommended 50-character limit at 78 characters.
Description check	✅ Passed	The description lists two specific technical accomplishments that align with the changeset modifications to git-pull-repos.sh and related shell script improvements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[josesimoes]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

.devcontainer/All/scripts/git-pull-repos.sh (1)

1-2: ⚠️ Potential issue | 🟡 Minor

Add a shebang to specify the shell interpreter.

The script begins with set -euo pipefail but lacks a shebang (#!/bin/bash). Without it, the script's behavior depends on whichever shell invokes it, potentially causing set -o pipefail to fail on non-Bash shells.

🔧 Proposed fix

+#!/bin/bash
 set -euo pipefail

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.devcontainer/All/scripts/git-pull-repos.sh around lines 1 - 2, Add a Bash
shebang at the very top of the script so the intended shell interpreter is
explicit: insert a line specifying "#!/usr/bin/env bash" (or "#!/bin/bash")
before the existing "set -euo pipefail" header to ensure "set -o pipefail" is
supported and the script runs under Bash consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.devcontainer/All/scripts/git-pull-repos.sh:
- Around line 39-41: The unguarded cd / should be made consistent with other
guarded directory changes: replace the bare "cd /" with a guarded change that
verifies the directory change succeeded and exits with an error message if it
fails (so the subsequent rm -rf /sources/ChibiOs and git svn clone commands
don't run on a failed cwd). Locate the "cd /" invocation in the script and wrap
it with a check that tests the cd result and logs a clear error before exiting
on failure.

---

Duplicate comments:
In @.devcontainer/All/scripts/git-pull-repos.sh:
- Around line 1-2: Add a Bash shebang at the very top of the script so the
intended shell interpreter is explicit: insert a line specifying "#!/usr/bin/env
bash" (or "#!/bin/bash") before the existing "set -euo pipefail" header to
ensure "set -o pipefail" is supported and the script runs under Bash
consistently.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 119ef98c-503d-465e-a0fd-3e57ce64d412

📥 Commits

Reviewing files that changed from the base of the PR and between fd62b44 and c89c0a9.

📒 Files selected for processing (1)

• .devcontainer/All/scripts/git-pull-repos.sh

[josesimoes]

@copilot In @.devcontainer/All/scripts/git-pull-repos.sh:

• Around line 1-2: Add a Bash shebang at the very top of the script so the
  intended shell interpreter is explicit: insert a line specifying "#!/usr/bin/env
  bash" (or "#!/bin/bash") before the existing "set -euo pipefail" header to
  ensure "set -o pipefail" is supported and the script runs under Bash
  consistently.

Also rebase this branch from main.

[Copilot]

@copilot In @.devcontainer/All/scripts/git-pull-repos.sh:

• Around line 1-2: Add a Bash shebang at the very top of the script so the
  intended shell interpreter is explicit: insert a line specifying ...

Added #!/usr/bin/env bash shebang as the first line of the script in commit 11dcc19. The branch has also been rebased from main.