Merged
Conversation
Deploying napi with
|
| Latest commit: |
d41ea5d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8f4af24b.napi-1ha.pages.dev |
| Branch Preview URL: | https://feature-improve-audit.napi-1ha.pages.dev |
florianbgt
commented
Feb 11, 2025
| } else { | ||
| targetEndpoint.group = group; | ||
| } | ||
| const updatedEndpoints = endpoints.map((e) => { |
Member
Author
There was a problem hiding this comment.
There was a small bug here with the sync. Out of scope of this PR, but it was a low hanging fruit so fixing it here.
florianbgt
commented
Feb 11, 2025
| // Skip if annotation is not valid, we assume it is a regular comment | ||
| return; | ||
| } catch (e) { | ||
| if (e instanceof CannotParseAnnotationError) { |
Member
Author
There was a problem hiding this comment.
Low hanging fruit too, better we handle the error explicitly
florianbgt
commented
Feb 11, 2025
| import { DepExport, DepImport, LanguagePlugin } from "./types"; | ||
| import { Group } from "../dependencyManager/types"; | ||
|
|
||
| class UnknownPlugin implements LanguagePlugin { |
Member
Author
There was a problem hiding this comment.
This is needed for the audit part. If a file is not supported, this plugin is used, which does nothing. We check that conditions when we parse the file within the audit part of the program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Please include a summary of the changes and the related issue. Explain the motivation behind this change.