native/map/enhc : add marker animation and press callback support#26
Merged
prakharritik merged 3 commits intomaster-testfrom Jan 19, 2026
Merged
native/map/enhc : add marker animation and press callback support#26prakharritik merged 3 commits intomaster-testfrom
prakharritik merged 3 commits intomaster-testfrom
Conversation
DharaneshSP
force-pushed
the
animate_marker_test
branch
from
7d45c2a to
eca9287
Compare
DharaneshSP
force-pushed
the
animate_marker_test
branch
from
d602ac4 to
89fafaf
Compare
- Implemented native Android marker animation for smoother marker movement - Added marker press callback bridging native → React Native
DharaneshSP
force-pushed
the
animate_marker_test
branch
from
89fafaf to
d66bf92
Compare
AyushMittal42
approved these changes
Jan 13, 2026
prakharritik
approved these changes
Jan 16, 2026
prakharritik
changed the title
|
|
||
| if (tag instanceof java.util.Map) { | ||
| java.util.Map tagMap = (java.util.Map) tag; | ||
| id = (String) tagMap.get("id"); |
Member
There was a problem hiding this comment.
can you add String type check here as well?
| } | ||
| if(!title.isEmpty()) { | ||
| Bitmap labelBitmap = createSimpleLabel(title); | ||
| com.google.android.gms.maps.model.MarkerOptions calloutMarkerOptions = new com.google.android.gms.maps.model.MarkerOptions() |
Member
There was a problem hiding this comment.
why do we need full package names here?
| if (originalBitmap != null) { | ||
|
|
||
| int targetWidthDp = 60; // only width in dp | ||
| int targetWidthDp = size; // only width in dp |
Member
There was a problem hiding this comment.
The default value of size is assigned 40, is the size of 60 coming from rn for nearby drivers as well?
PraveenGongada
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does any other open PR do the same thing?
(please answer here)
What issue is this PR fixing?
(please link the issue here)
How did you test this PR?
(please answer here)