[fw] refactor incoming Interest processing #179
[fw] refactor incoming Interest processing #179r2dev2 wants to merge 34 commits intonamed-data:dv2from
Conversation
…e overly harsh test restrictions
|
requesting @tianyuan129 review e2e passes locally but not in ci. debugging why ci is failing but that can be addressed in new pr |
tianyuan129
changed the title
| core.Log.Debug(s, "No usable nexthop for Interest - DROP", "name", packet.Name) | ||
| } | ||
|
|
||
| func (s *BestRoute) AfterReceiveMulticastInterest( |
There was a problem hiding this comment.
Why a bestroute strategy can receive a multicast Interest? The interest is steered toward the multicast pipeline.
There was a problem hiding this comment.
It is implementing a base method of Strategy class. I needed a different signature for multicast strategies so I made a new method AfterReceiveMulticastInterest and log an error in the functions that should not be called. The surrounding logic prevents them from being called so this function is never called.
fw/fw/bier_strategy.go
Outdated
| nextER []enc.Name, | ||
| nexthops []StrategyCandidateHop, | ||
| ) { | ||
| core.Log.Error(s, "BierStrategy does not support AfterReceiveInterest (unicast)", |
There was a problem hiding this comment.
Same here. It should be already insulated from unicast.
| } | ||
| } | ||
|
|
||
| func (s *Multicast) AfterReceiveMulticastInterest( |
There was a problem hiding this comment.
I am a bit lost, I thought the word "multicast" is elevated to a forwarding pipeline, and stop being a strategy?
…hoice + remove unneeded strategy name normalization
fw/mgmt/strategy-choice.go
Outdated
| return | ||
| } | ||
|
|
||
| table.MulticastStrategyTable.SetStrategyEnc(params.Name, params.Strategy.Name) |
There was a problem hiding this comment.
Looking back, should we call it a BIFTStrategy (in contrast to FibStrategy)?
There was a problem hiding this comment.
I think MulticastStrategy is more fitting as only BIER makes use of BIFT and the table contains other strategies like broadcast.
| entries := table.FibStrategyTable.GetAllForwardingStrategies() | ||
| var entries []table.FibStrategyEntry | ||
| name := LOCAL_PREFIX.Append( | ||
| enc.NewGenericComponent("strategy-choice"), |
There was a problem hiding this comment.
Should we make it explicit it it a unicast strategy choice?
|
OK. now the the question is can we fix e2e? |
3 participants
Uh oh!
There was an error while loading. Please reload this page.