fix(nap_pmp): reject buffers that are too short on responses#34
Merged
divagant-martian merged 3 commits intomainfrom Sep 8, 2025
Merged
fix(nap_pmp): reject buffers that are too short on responses#34divagant-martian merged 3 commits intomainfrom
divagant-martian merged 3 commits intomainfrom
Conversation
divagant-martian
changed the title
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/34/docs/net_tools/ Last updated: 2025-09-08T04:48:29Z |
dignifiedquire
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a panic in decoding a response from the nat box due to incorrect buffer size verifications. We were checking that the buffer size is within range for all different kinds of responses, but for the specific map response the buffer size is exact.
Also updates some libraries due to advisories
Notes & open questions
Change checklist