feat(netwatch, portmapper): Switch from thiserror to snafu#24
Merged
dignifiedquire merged 14 commits intomainfrom May 5, 2025
Merged
feat(netwatch, portmapper): Switch from thiserror to snafu#24dignifiedquire merged 14 commits intomainfrom
thiserror to snafu#24dignifiedquire merged 14 commits intomainfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/24/docs/net_tools/ Last updated: 2025-05-05T06:59:24Z |
ramfox
reviewed
May 2, 2025
ramfox
approved these changes
May 2, 2025
Member
ramfox
left a comment
ramfox
left a comment
There was a problem hiding this comment.
double-checked all the ensure logic, congrats on not making any mistakes 😂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Try to switch from thiserror to snafu.
Breaking Changes
Error variants changed shape a bit, generally use
#[non_exhaustive]and contain a namedsource: OtherErrorfield instead of wrapping an unnamedOtherError, and in addition have abacktrace: Option<snafu::Backtrace>.Change checklist