docs: recommend quoting for portability#260
Open
dsherret wants to merge 1 commit intomysticatea:masterfrom
Open
docs: recommend quoting for portability#260dsherret wants to merge 1 commit intomysticatea:masterfrom
dsherret wants to merge 1 commit intomysticatea:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current recommendation relies on the user's shell's glob handling behaviour. It happens to work because generally
something:*does not match any files, and so with sh's default behaviour it passessomething:*as-is as an arg. This breaks down in some other shells though, for example, with zsh:...or with yarn, as referenced in the issues that will be closed by this PR.
This change recommends quoting the globs with single quotes, which will avoid the glob expansion (which requires traversing the file system) and will also be more portable to work in more cases.
Closes #200
Closes #196