WIP Only allow visible requests in project queues#9188
Draft
garethrees wants to merge 1 commit intodevelopfrom
Draft
WIP Only allow visible requests in project queues#9188garethrees wants to merge 1 commit intodevelopfrom
garethrees wants to merge 1 commit intodevelopfrom
Conversation
Contributors shouldn't see hidden or requester_only requests. The tests for this are a bit confusing and not currently passing. Need to check what happens in views only the requester has access to – do we show them requester_only stuff there? Or do we just make this a limitation on projects that it can't be used with reduced prominence requests? Probably the latter.
garethrees
commented
Apr 2, 2026
|
|
||
| def classifiable | ||
| where(awaiting_description: true) | ||
| where(awaiting_description: true, prominence: %[normal backpage]) |
Member
Author
There was a problem hiding this comment.
Can't use is_public scope as that excludes private requests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributors shouldn't see hidden or requester_only requests.
The tests for this are a bit confusing and not currently passing.
Need to check what happens in views only the requester has access to – do we show them requester_only stuff there? Or do we just make this a limitation on projects that it can't be used with reduced prominence requests? Probably the latter.