Fix hidden request snippets in embargoed batches#9185
Merged
Conversation
Hidden requests should only be viewable by admins. Not much is revealed here, other than the existence of the request and a snippet generated from the last message on the thread, but this _could_ be a problem in a small number of cases. Introduced in 9808d5a. Not sure why hidden requests were explicitly included back then.
sagepe
force-pushed
the
batch-list-prominence
branch
from
2dd79bc to
4000635
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hidden requests should only be viewable by admins. Not much is revealed
here, other than the existence of the request and a snippet generated
from the last message on the thread, but this could be a problem in a
small number of cases.
Introduced in 9808d5a. Not sure why hidden requests were explicitly
included back then.