Skip to content

Fix attachment visibility check#9179

Merged
garethrees merged 1 commit intodevelopfrom
batch-zip-download-attachment-check
Mar 24, 2026
Merged

Fix attachment visibility check#9179
garethrees merged 1 commit intodevelopfrom
batch-zip-download-attachment-check

Conversation

@garethrees
Copy link
Copy Markdown
Member

Update visibility checks for downloading zip files of batch requests now that an FoiAttachment can have prominence set independently of the parent IncomingMessage.

Update visibility checks for downloading zip files of batch requests now
that an `FoiAttachment` can have prominence set independently of the
parent `IncomingMessage`.
Copy link
Copy Markdown
Member

@gbp gbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested - but I can't see any issue with this change.

@garethrees garethrees marked this pull request as ready for review March 24, 2026 16:32
@garethrees
Copy link
Copy Markdown
Member Author

# BEFORE

$ tree batch-1-exdfbginuyvt-export-2026-03-24-143017
batch-1-exdfbginuyvt-export-2026-03-24-143017
├── .DS_Store
├── batch-1-exdfbginuyvt-dashboard-2026-03-24-143017.csv
├── Department for Humpadinking - exdfbginuyvt
│   └── 2026-03-24-135805
│       └── outgoing_12.txt
└── Geraldine Quango - exdfbginuyvt_2
    ├── .DS_Store
    ├── 2012-01-08-091615                   <<---------------------- HIDDEN ATTACHMENT PRESENT
    │   ├── .DS_Store
    │   ├── attachments-8
    │   │   └── fs 50379341.pdf 
    │   └── incoming_8.txt
    └── 2026-03-24-135905
        └── outgoing_13.txt

7 directories, 8 files

# AFTER

$ tree batch-1-exdfbginuyvt-export-2026-03-24-163225
batch-1-exdfbginuyvt-export-2026-03-24-163225
├── .DS_Store
├── batch-1-exdfbginuyvt-dashboard-2026-03-24-163225.csv
├── Department for Humpadinking - exdfbginuyvt
│   ├── .DS_Store
│   └── 2026-03-24-135805
│       └── outgoing_12.txt
└── Geraldine Quango - exdfbginuyvt_2
    ├── .DS_Store
    ├── 2012-01-08-091615                   <<---------------------- HIDDEN ATTACHMENT NOT PRESENT
    │   └── incoming_8.txt
    └── 2026-03-24-135905
        └── outgoing_13.txt

6 directories, 7 files

@garethrees garethrees merged commit c95d8f5 into develop Mar 24, 2026
5 checks passed
@garethrees garethrees deleted the batch-zip-download-attachment-check branch March 24, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants