Merged
Conversation
90% of the time you use a button_to like a link_to so want it to be displayed as one. Without this the form is `display:block`.
When we use the `button_to` helper a form is generated with a button inside the form element. Bootstrap doesn't expect this so the btn-group styling breaks. This CSS enables mixed link-based/form-based buttons to be correctly grouped.
Disabled on a link is only presentational, so we need to use button_to in order to truly disable these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Broke in b869305 as part of #8803.
What does this do
Fix disabled buttons still submitting. Disabled on a link is only presentational, so we need to use
button_toin order to truly disable these.Also adds some CSS fixes to make the
button_toversions look as intended.Screenshots
btn-groupfix works with button in each position:[skip changelog]