Add basic rendering of body category notes#9056
Open
garethrees wants to merge 2 commits intodevelopfrom
Open
Conversation
Prior to this commit we could create notes for public body categories, but they were not rendered. This is also true for the `Category#body` rich text attribute. This adds basic rendering of these elements using the same pattern as for request categories.
Make the category page a bit more coherent by rendering the category heading as the more prominent page heading and de-emphasise the number of results; fall back to the big results list for searches by tag or other searches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit we could create notes for public body categories, but they were not rendered. This also applies to the
Category#descriptiontext.This adds basic rendering of these elements using the same pattern as for request categories.
Improves the layout in bfe02ef:
Category with notes/body. Uses the main category title:
Category with title only. Uses the main category title:
List by tag. Falls back to previous heading:
List by search term. Falls back to previous heading: