Open
Conversation
garethrees
changed the title
garethrees
force-pushed
the
8906-prevent-on-site-citations
branch
from
82b5eb7 to
1cb0a91
Compare
We've seen a few cases where Citations have been added where the source_url is a link to the Alaveteli site. * In a few cases the requester has added a Citation linking to the request the citation was added to * A user included a confirmation URL, which when followed logged you in to their account * In one case a user legitimately added a citation to another request, where the request was based on a previous response In most cases citations are intended to be more about external sources that link to the platform. Fixes #8906.
garethrees
force-pushed
the
8906-prevent-on-site-citations
branch
from
b10848f to
d272ddf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen a few cases where Citations have been added where the source_url is a link to the Alaveteli site.
In most cases citations are intended to be more about external sources that link to the platform.
Fixes #8906.
Notes to reviewer
Do we have a helper instead of using the full
AlaveteliConfiguration.domaincall? Don't think its worth adding just for this, but if we've got something shorter I'll push a fixup.