fix: prevent stale ACEE pointer in ASXBSENV after racf_logout#28
Merged
mgrossmann merged 1 commit intomainfrom Mar 20, 2026
Merged
fix: prevent stale ACEE pointer in ASXBSENV after racf_logout#28mgrossmann merged 1 commit intomainfrom
mgrossmann merged 1 commit intomainfrom
Conversation
racf_logout compared oldacee against *acee AFTER RACINIT DELETE, which zeroes *acee. When oldacee was the same ACEE being deleted (set by a prior RACINIT CREATE), the comparison always took the restore branch, writing the freed pointer back into ASXBSENV. Save *acee before RACINIT DELETE and compare against that instead, so the equality case correctly clears ASXBSENV to NULL. Fixes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
Problem
racf_logout()comparedoldacee(saved ASXBSENV) against*aceeafterRACINIT DELETE, which zeroes*acee. WhenRACINIT CREATEhad previously anchored the same ACEE in ASXBSENV, the comparisonoldacee != *aceealways evaluated to TRUE, writing the freed pointer back into ASXBSENV.This caused S0C4 abends in any subsequent code calling
racf_get_acee()— observed in UFSD SSI router during Zowe Explorer file retrieval.Fix
Save
*aceeindelaceebeforeRACINIT DELETEand compareoldaceeagainst that stable value. When they match (ASXBSENV pointed to the deleted ACEE), ASXBSENV is cleared to NULL instead of restoring the freed pointer.Test plan
make build && make link)