fix: missing template specifier for std::mutex#6
Open
mhasel wants to merge 1 commit intomun-lang:mainfrom
Open
fix: missing template specifier for std::mutex#6mhasel wants to merge 1 commit intomun-lang:mainfrom
mhasel wants to merge 1 commit intomun-lang:mainfrom
Conversation
Adds a template specifier to the std::unique_lock call in mun_lld_link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
std::mutextemplate specifier to thestd::unique_lockcall inmun_lld_linkin order to fix C++ errors when trying to buildlld-rs v140.0.0.Additional context
We have noticed our docker container in our CI was no longer building successfully for the past 3 days due to the following error:
We have not made any changes to our container in the past 3 months and were unable to build
lld-rslocally either, incurring the same error. Adding the specific template type fixes this build issue.