[x-license] add cross-major license format compatibility tests#22335
Open
aemartos wants to merge 7 commits intomui:masterfrom
Open
[x-license] add cross-major license format compatibility tests#22335aemartos wants to merge 7 commits intomui:masterfrom
aemartos wants to merge 7 commits intomui:masterfrom
Conversation
aemartos
added
internal
…aemartos/mui-x into feature/sto-156-x-license-improve-tests
Deploy previewhttps://deploy-preview-22335--material-ui-x.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
…aemartos/mui-x into feature/sto-156-x-license-improve-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test workspace at
test/x-license-compat/that pins every published x-license major (v5/v6/v7/v8/v9) and runs each currently-issued license-key format through every older verifyLicense. The matrix exists to catch backwards-compat regressions early, if a future change makes a new license format unreadable by an older major, this suite fails.What's covered
Three axes:
x-data-grid-pro,x-charts-pro,x-tree-view-pro.Cells that exercise known historical limitations (v5 lacks
annual; v7+ gates charts/tree-view on Q3-2024+) are filtered with explanatory comments.KV=3 cells on v5–v8 are marked
it.fails.each(...)because we can't roll back KV=3 (~36 keys already issued) and older majors can't decode it. The marker keeps the suite green while documenting the bite.Notes
__ALLOW_TEST_LICENSES__=falseguard in pinned v9's compiled source so test fixtures aren't rejected. Scoped toverifyLicense.{m,}js, nothing else is affected.TEST_KEY_PRO_ANNUAL_Q1_2026(KV=2) fixture is added inpackages/x-license/src/test-keys.tsto cover the Q1-2026 annual case in the matrix.@mui/x-licensebundle, pinned older majors are devDeps of the test workspace.