[pickers] Merge slotProps.sectionContent in PickersInputBase#22324
Open
rin wants to merge 2 commits intomui:masterfrom
Open
[pickers] Merge slotProps.sectionContent in PickersInputBase#22324rin wants to merge 2 commits intomui:masterfrom
rin wants to merge 2 commits intomui:masterfrom
Conversation
rin
force-pushed
the
fix/pickers-merge-section-content-slot-props
branch
from
462f711 to
f7df1f4
Compare
rin
force-pushed
the
fix/pickers-merge-section-content-slot-props
branch
from
f7df1f4 to
f9812aa
Compare
Deploy previewhttps://deploy-preview-22324--material-ui-x.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this when trying to put props on each date/time segment for accessibility (aria attributes for the spin buttons). The
slotPropsdon't get passed through all the way, because the internalPickersInputBaseis replacing the section slot props, instead of merging in any passedsectionContentslot props.